Checking cyber-bao v0.1.0 (/private/tmp/radio-kadek-traversal.Oy2m4r/candidate/cyber-bao)
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/mixed.rs:115:32
|
115 | stack.push(pair.1.clone());
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pair.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/mixed.rs:118:32
|
118 | stack.push(pair.0.clone());
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `pair.0`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/sync.rs:59:32
|
59 | stack.push(r_hash.clone());
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `r_hash`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/sync.rs:62:32
|
62 | stack.push(l_hash.clone());
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `l_hash`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/sync.rs:183:27
|
183 | next.push(level[i].clone());
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level[i]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: this function has too many arguments (9/7)
--> cyber-bao/src/io/sync.rs:239:1
|
239 | / async fn validate_node_rec<O, D>(
240 | | outboard: &O,
241 | | data: &D,
242 | | backend: &Poseidon2Backend,
... |
251 | | O: Outboard<Hash = hemera::Hash>,
252 | | D: ReadAt,
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
error: large size difference between variants
--> cyber-bao/src/io/fsm.rs:53:1
|
53 | / pub enum ResponseDecoderNext<R> {
54 | | /// More items available. Contains the decoder and the next item/error.
55 | |/ More(
56 | || (
57 | || ResponseDecoder<R>,
58 | || Result<BaoContentItem<hemera::Hash>, DecodeError>,
59 | || ),
60 | || ),
| ||_____- the largest variant contains at least 504 bytes
61 | | /// Decoding is complete.
62 | | Done(R),
| | ------- the second-largest variant contains at least 0 bytes
63 | | }
| |__^ the entire enum is at least 504 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#large_enum_variant
= note: `-D clippy::large-enum-variant` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
56 ~ Box<(
57 + ResponseDecoder<R>,
58 + Result<BaoContentItem<hemera::Hash>, DecodeError>,
59 ~ )>,
|
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/fsm.rs:106:20
|
106 | stack.push(hash.clone());
| ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/fsm.rs:188:38
|
188 | inner.stack.push(right.clone());
| ^^^^^^^^^^^^^ help: try removing the `clone` call: `right`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/fsm.rs:191:38
|
191 | inner.stack.push(left.clone());
| ^^^^^^^^^^^^ help: try removing the `clone` call: `left`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/mod.rs:72:27
|
72 | next.push(level[i].clone());
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level[i]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: this `if` statement can be collapsed
--> cyber-bao/src/tree.rs:733:9
|
733 | / if left_overlaps {
734 | | if let Some(left) = left_child {
735 | | self.pre_order_filtered_recurse(left, false, total_blocks, ranges, out);
736 | | }
737 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
= note: `-D clippy::collapsible-if` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
|
733 ~ if left_overlaps
734 ~ && let Some(left) = left_child {
735 | self.pre_order_filtered_recurse(left, false, total_blocks, ranges, out);
736 ~ }
|
error: this `if` statement can be collapsed
--> cyber-bao/src/tree.rs:738:9
|
738 | / if right_overlaps {
739 | | if let Some(right) = right_child {
740 | | self.pre_order_filtered_recurse(right, false, total_blocks, ranges, out);
741 | | }
742 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#collapsible_if
help: collapse nested if block
|
738 ~ if right_overlaps
739 ~ && let Some(right) = right_child {
740 | self.pre_order_filtered_recurse(right, false, total_blocks, ranges, out);
741 ~ }
|
error: could not compile `cyber-bao` (lib) due to 13 previous errors
warning: build failed, waiting for other jobs to finish...
error: using `clone` on type `Hash` which implements the `Copy` trait
--> cyber-bao/src/io/pre_order.rs:353:19
|
353 | root: ob.root.clone(),
| ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ob.root`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#clone_on_copy
error: this loop could be written as a `while let` loop
--> cyber-bao/src/io/fsm.rs:268:9
|
268 | / loop {
269 | | match current.next().await {
270 | | ResponseDecoderNext::More((dec, result)) => {
271 | | let item = result.expect("decode should succeed");
... |
279 | | }
| |_________^ help: try: `while let ResponseDecoderNext::More((dec, result)) = current.next().await { .. }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#while_let_loop
= note: `-D clippy::while-let-loop` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::while_let_loop)]`
error: this loop could be written as a `while let` loop
--> cyber-bao/src/io/fsm.rs:307:9
|
307 | / loop {
308 | | match current.next().await {
309 | | ResponseDecoderNext::More((dec, result)) => {
310 | | let item = result.expect("decode should succeed");
... |
318 | | }
| |_________^ help: try: `while let ResponseDecoderNext::More((dec, result)) = current.next().await { .. }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.95.0/index.html#while_let_loop
error: could not compile `cyber-bao` (lib test) due to 16 previous errors